VMware: match nic mac for ip address fetch #10641

alexandru-bagu · 2025-03-29T11:58:37Z

Description

This PR fixes #10640

The main solution for the issue here would be to make sure that we are getting the IP for the correct NIC which we can do based on the MAC of the NIC. Additionally, a null IP is also a valid response because a NIC can have no IP assigned.

It's up for discussion whether we should pull any IP even if it does not match the network subnet because the user can in fact use the NIC with another subnet as well, but that is not necessarily relevant to this issue.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

I am in the process of testing on my dev environment then going to push in prod once I am happy with the results.

How did you try to break this feature and the system with this change?

weizhouapache

overall looks good

A related pr for l2 network #10431

weizhouapache · 2025-03-29T12:24:10Z

@blueorangutan package

blueorangutan · 2025-03-29T12:26:04Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

server/src/main/java/com/cloud/vm/UserVmManagerImpl.java

alexandru-bagu · 2025-03-29T13:01:21Z

overall looks good

A related pr for l2 network #10431

Interesting. I see your PR has more changes than this PR. Feel free to grab my code for VMware and close this PR.

blueorangutan · 2025-03-29T13:33:24Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12924

codecov · 2025-03-29T19:14:25Z

Codecov Report

❌ Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.17%. Comparing base (36cfd76) to head (cddab12).
⚠️ Report is 8 commits behind head on 4.20.

Files with missing lines	Patch %	Lines
...oud/hypervisor/vmware/resource/VmwareResource.java	0.00%	11 Missing ⚠️
.../src/main/java/com/cloud/vm/UserVmManagerImpl.java	0.00%	9 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               4.20   #10641   +/-   ##
=========================================
  Coverage     16.17%   16.17%           
+ Complexity    13296    13295    -1     
=========================================
  Files          5656     5656           
  Lines        498219   498253   +34     
  Branches      60451    60462   +11     
=========================================
+ Hits          80579    80585    +6     
- Misses       408672   408697   +25     
- Partials       8968     8971    +3

Flag	Coverage Δ
uitests	`4.00% <ø> (-0.01%)`	⬇️
unittests	`17.02% <0.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

weizhouapache · 2025-04-17T14:02:41Z

@blueorangutan package

blueorangutan · 2025-04-17T14:04:03Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-04-17T15:34:28Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13098

weizhouapache · 2025-04-25T06:27:51Z

@alexandru-bagu
can you rebase with 4.20 branch so it will be included into 4.20.1.0 release ?

blueorangutan · 2025-10-01T13:20:04Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

...ns/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java

weizhouapache · 2025-10-01T14:20:18Z

@blueorangutan package

blueorangutan · 2025-10-01T14:22:04Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-10-01T14:44:32Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15255

weizhouapache · 2025-10-01T15:23:28Z

@blueorangutan test

blueorangutan · 2025-10-01T15:24:03Z

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-10-01T15:52:10Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15256

weizhouapache · 2025-10-01T16:33:14Z

@blueorangutan test ol8 vmware-80u3

blueorangutan · 2025-10-01T16:34:04Z

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-80u3) has been kicked to run smoke tests

blueorangutan · 2025-10-02T07:18:52Z

[SF] Trillian test result (tid-14505)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 53992 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10641-t14505-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

weizhouapache · 2025-10-02T08:05:30Z

verified OK on both

shared network without services (QuickCloud with no services) and
L2 networks

tested with ubuntu cloud image

assigned Ip manually

waited a while

reboot the vm, the assigned IP is gone, the IP field is empty

assigned another IP inside the vm

new IP is fetched

blueorangutan · 2025-10-02T21:11:09Z

[SF] Trillian test result (tid-14506)
Environment: vmware-80u3 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 100089 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10641-t14506-vmware-80u3.zip
Smoke tests completed. 138 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_deploy_more_vms_than_limit_allows	`Error`	216.66	test_deploy_vms_in_parallel.py
test_01_deployVMInSharedNetwork	`Failure`	679.90	test_network.py
test_02_list_snapshots_with_removed_data_store	`Error`	12.72	test_snapshots.py
test_02_list_snapshots_with_removed_data_store	`Error`	12.73	test_snapshots.py

vishesh92

clgtm

server/src/main/java/com/cloud/vm/UserVmManagerImpl.java

...ns/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java

Co-authored-by: Vishesh <[email protected]>

…vmware/resource/VmwareResource.java Co-authored-by: Vishesh <[email protected]>

weizhouapache · 2025-10-03T07:42:58Z

@blueorangutan package

blueorangutan · 2025-10-03T07:44:04Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-10-03T09:15:03Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15272

weizhouapache · 2025-10-03T10:33:57Z

@blueorangutan test ol8 vmware-80u3

blueorangutan · 2025-10-03T10:36:06Z

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-80u3) has been kicked to run smoke tests

blueorangutan · 2025-10-04T08:06:51Z

[SF] Trillian test result (tid-14514)
Environment: vmware-80u3 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 74810 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10641-t14514-vmware-80u3.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_scale_vm	`Error`	1.59	test_scale_vm.py
test_02_scale_vm_negative_offering_disable_scaling	`Error`	1.40	test_scale_vm.py
test_03_scale_vm_negative_vm_disable_scaling	`Error`	1.41	test_scale_vm.py
test_04_scale_vm_with_user_account	`Error`	11.64	test_scale_vm.py

boring-cyborg bot added component:api component:vmware component:XenServer labels Mar 29, 2025

alexandru-bagu force-pushed the fix-vmware-ip-loss branch from f8296f2 to d3939f0 Compare March 29, 2025 12:13

weizhouapache reviewed Mar 29, 2025

View reviewed changes

alexandru-bagu commented Mar 29, 2025

View reviewed changes

server/src/main/java/com/cloud/vm/UserVmManagerImpl.java Show resolved Hide resolved

weizhouapache linked an issue Mar 29, 2025 that may be closed by this pull request

Autodetect IPs used inside the VM #7142

Open

Pearl1594 added this to the 4.21.0 milestone Apr 3, 2025

weizhouapache self-assigned this Apr 10, 2025

weizhouapache added this to Apache CloudStack BugFest - Issues Apr 15, 2025

weizhouapache moved this to Todo in Apache CloudStack BugFest - Issues Apr 15, 2025

weizhouapache changed the title ~~match nic mac for ip address fetch~~ VMware: match nic mac for ip address fetch Apr 17, 2025

weizhouapache changed the base branch from main to 4.20 April 25, 2025 06:27

boring-cyborg bot added component:agent component:build labels Apr 25, 2025

weizhouapache changed the base branch from 4.20 to main April 25, 2025 06:27

Alexandru Bagu added 3 commits April 25, 2025 11:07

match nic mac for ip address fetch

559c011

rename field to properly match usage

4a40b00

rebase to 4.20 and adapt code to match other PR

2726aca

alexandru-bagu force-pushed the fix-vmware-ip-loss branch from d3939f0 to 2726aca Compare April 25, 2025 09:38

boring-cyborg bot added the component:compute label Apr 25, 2025

weizhouapache reviewed Oct 1, 2025

View reviewed changes

...ns/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java Outdated Show resolved Hide resolved

fix ip fetch on L2 network

230412d

weizhouapache approved these changes Oct 2, 2025

View reviewed changes

vishesh92 approved these changes Oct 3, 2025

View reviewed changes

vishesh92 reviewed Oct 3, 2025

View reviewed changes

server/src/main/java/com/cloud/vm/UserVmManagerImpl.java Outdated Show resolved Hide resolved

vishesh92 reviewed Oct 3, 2025

View reviewed changes

...ns/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java Show resolved Hide resolved

weizhouapache and others added 2 commits October 3, 2025 09:27

Update server/src/main/java/com/cloud/vm/UserVmManagerImpl.java

ccce3e9

Co-authored-by: Vishesh <[email protected]>

Update plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/…

cddab12

…vmware/resource/VmwareResource.java Co-authored-by: Vishesh <[email protected]>

weizhouapache added the status:ready-for-merge label Oct 3, 2025

weizhouapache merged commit 8e4dc0a into apache:4.20 Oct 4, 2025
25 of 26 checks passed

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Oct 17, 2025

VMware: match nic mac for ip address fetch (apache#10641)

0b9b688

sandeeplocharla pushed a commit to NetApp/cloudstack that referenced this pull request Oct 21, 2025

VMware: match nic mac for ip address fetch (apache#10641)

6da9414

VMware: match nic mac for ip address fetch #10641

VMware: match nic mac for ip address fetch #10641

Uh oh!

Conversation

alexandru-bagu commented Mar 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

weizhouapache left a comment

Choose a reason for hiding this comment

Uh oh!

weizhouapache commented Mar 29, 2025

Uh oh!

blueorangutan commented Mar 29, 2025

Uh oh!

Uh oh!

alexandru-bagu commented Mar 29, 2025

Uh oh!

blueorangutan commented Mar 29, 2025

Uh oh!

codecov bot commented Mar 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

weizhouapache commented Apr 17, 2025

Uh oh!

blueorangutan commented Apr 17, 2025

Uh oh!

blueorangutan commented Apr 17, 2025

Uh oh!

weizhouapache commented Apr 25, 2025

Uh oh!

blueorangutan commented Oct 1, 2025

Uh oh!

Uh oh!

weizhouapache commented Oct 1, 2025

Uh oh!

blueorangutan commented Oct 1, 2025

Uh oh!

blueorangutan commented Oct 1, 2025

Uh oh!

weizhouapache commented Oct 1, 2025

Uh oh!

blueorangutan commented Oct 1, 2025

Uh oh!

blueorangutan commented Oct 1, 2025

Uh oh!

weizhouapache commented Oct 1, 2025

Uh oh!

blueorangutan commented Oct 1, 2025

Uh oh!

blueorangutan commented Oct 2, 2025

Uh oh!

weizhouapache commented Oct 2, 2025

Uh oh!

blueorangutan commented Oct 2, 2025

Uh oh!

vishesh92 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

weizhouapache commented Oct 3, 2025

Uh oh!

blueorangutan commented Oct 3, 2025

Uh oh!

blueorangutan commented Oct 3, 2025

Uh oh!

weizhouapache commented Oct 3, 2025

Uh oh!

blueorangutan commented Oct 3, 2025

Uh oh!

blueorangutan commented Oct 4, 2025

alexandru-bagu commented Mar 29, 2025 •

edited

Loading

codecov bot commented Mar 29, 2025 •

edited

Loading